fix: ensure date-time is ISO format
#75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixeltrix
reviewed
Nov 28, 2023
schema/schema.json
Outdated
| "format": "date-time", | ||
| "pattern": "^[0-9]{4}-((0[13578]|1[02])-(0[1-9]|[12][0-9]|3[01])|(0[469]|11)-(0[1-9]|[12][0-9]|30)|(02)-(0[1-9]|[12][0-9]))T(0[0-9]|1[0-9]|2[0-3]):(0[0-9]|[1-5][0-9]):(0[0-9]|[1-5][0-9])\\.[0-9]{3}Z$", |
There was a problem hiding this comment.
This regex is too strict now - according to the RFC 3339 spec the second fraction is optional and is any number of digits. Also the T and Z may be upper/lower case and timezone offsets are allowed, e.g. 2023-08-31T00:00:00+01:00.
There was a problem hiding this comment.
Thanks for catching, examples updated to catch these more diverse scenarios and regex sourced from here now
DafyddLlyr
approved these changes
Nov 28, 2023
| @@ -1227,7 +1227,9 @@ | |||
| "type": "string" | |||
| }, | |||
| "DateTime": { | |||
| "description": "Regex-based implementation of iso-date-time until available in [email protected]", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ajv-formats&jsonschemaboth permit a flexible interpretation ofdate-timethat allows spaces, but we want to restrict to an ISO timestamp as flagged by BOPS.The
iso-date-timeformat won't be available untilajv-formatsv3.0.0 is released, so I'm combining the existingdate-timewith a regex@patternfor now. There's a numer of existing issue threads on this topic, eg ajv-validator/ajv-formats#55